AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Add a border to the selected Unsplash image.

Open LucasXu0 opened this issue 1 year ago • 3 comments

Description

Currently, only the built-in images are given a border when selected. We should also add a border to selected Unsplash images.

Screenshot 2024-05-13 at 13 34 50 Screenshot 2024-05-13 at 13 33 39

Impact

Make the UI consistent.

Additional Context

Related file: https://github.com/AppFlowy-IO/AppFlowy/tree/main/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart

LucasXu0 avatar May 13 '24 05:05 LucasXu0

Hey @LucasXu0 I can't understand what you are trying to do. so can you explain a bit more clearly it was very important to build a new feature for this community.

sudhar08 avatar May 19 '24 16:05 sudhar08

Hey @LucasXu0 I can't understand what you are trying to do. so can you explain a bit more clearly it was very important to build a new feature for this community.

In the first image that Lucas attached to the issue report, under the Background image category, you see that the selected image has a blue border with some spacing and then the image.

Now in the second image attached, you see how selecting an Unsplash image looks, but if the unsplash image is already the selected image, there is no blue border indicating this.

This issue aims to address this discrepancy, by adding the same border from the first picture, to the unsplash image if it is the currently used (selected) one.

Xazin avatar May 19 '24 20:05 Xazin

@Xazin Thank you for explaining

sudhar08 avatar May 20 '24 03:05 sudhar08