py-solc-x icon indicating copy to clipboard operation
py-solc-x copied to clipboard

import solc versions installed via solc-select

Open f0rki opened this issue 3 years ago • 2 comments
trafficstars

What I did

Search the path used by solc-select for solidity versions to import.

Related issue: #122

How I did it

glob ~/.solc-select/artifacts for installed solc binaries.

How to verify it

$ rm -rf ~/.solcx ~/.solc-select
$ pip install solc-select
[...]
$ solc-select install 0.4.26 0.7.6
Installing '0.7.6'...
Version '0.7.6' installed.
Installing '0.4.26'...
Version '0.4.26' installed.
$ python -c 'import solcx; print(solcx.import_installed_solc())'
[Version('0.7.6'), Version('0.4.26')]

Checklist

  • [x] I have confirmed that my PR passes all linting checks
  • [ ] I have included test cases
  • [ ] I have updated the documentation (README.md)
  • [ ] I have added an entry to the changelog

f0rki avatar Dec 10 '21 19:12 f0rki

I am not sure on how to add test cases for this and whether this is even needed?

f0rki avatar Dec 10 '21 19:12 f0rki

Somewhat related: it might be a good idea to use symlinks when sharing a lot of solc versions with solc-select. But I am not sure, whether this results in other issues.

f0rki avatar Dec 10 '21 20:12 f0rki

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

github-actions[bot] avatar Dec 08 '23 01:12 github-actions[bot]

This PR was closed because it has been inactive for 35 days.

github-actions[bot] avatar Dec 13 '23 01:12 github-actions[bot]