ape icon indicating copy to clipboard operation
ape copied to clipboard

Async web3 provider

Open BobTheBuidler opened this issue 3 years ago • 2 comments

What I did

Added AsyncProviderAPI, AsyncWeb3Provider, AsyncGethProvider classes

How I did it

I essentially copied the existing providers and just made everything async. There are also a few instances where I had to add async versions of functions in various parts of the code.

How to verify it

Try the various methods you would expect to work from a Geth provider. (eth_call, eth_getLogs, ...)

Checklist

  • [ ] All changes are completed
  • [ ] New test cases have been added
  • [ ] Documentation has been updated

BobTheBuidler avatar Jul 22 '22 21:07 BobTheBuidler

@fubuloubu I think this is a huge addition

johnson2427 avatar Jul 29 '22 03:07 johnson2427

@fubuloubu I think this is a huge addition

Yes, it's 853 lines to be exact

In all seriousness, I love the submission, but we have to think about how it fits into the overall library before eopening this rabbit hole

fubuloubu avatar Jul 29 '22 03:07 fubuloubu

Let's add a link to this PR to the async ticket and close it out, it is a bit noisy right now and stale.

antazoey avatar Mar 24 '23 14:03 antazoey

@BobTheBuidler going to close, as this is like a year old and, full of conflicts, and different than what we want. Let's set up a meeting to discuss. Post in Telegram or something.

antazoey avatar May 23 '23 12:05 antazoey