ape icon indicating copy to clipboard operation
ape copied to clipboard

feat: expose 'data' (query-manager) as a top-level object

Open antazoey opened this issue 1 year ago • 2 comments

What I did

Allows

from ape import queries

How I did it

How to verify it

Checklist

  • [ ] All changes are completed
  • [ ] New test cases have been added
  • [ ] Documentation has been updated

antazoey avatar Aug 26 '24 17:08 antazoey

maybe querier makes more sense but not an easy word to remember how to type

antazoey avatar Aug 26 '24 17:08 antazoey

What would be the use case for exposing this?

Users just trying to work with query manager more directly, like especially when you are trying to use a specific engine. One example is even testing a query-engine plugin directly.

Otherwise, I can do this, but it just felt awkward:

@pytest.fixture
def query_engine():
    return ManagerAccessMixin.query_manager.engines["etherscan"]

antazoey avatar Aug 26 '24 18:08 antazoey