ape-etherscan icon indicating copy to clipboard operation
ape-etherscan copied to clipboard

Published 20 hours ago • verified publisher icon ApeWorX

fix: Allow NONE licenses without logging errors (also completes comments for license types)

Open sreyemnayr opened this issue 1 year ago • 7 comments

What I did

Added keys for intentionally unlicensed (not to be confused with the "Unlicense" 🙃 ) source code without an error.

fixes: #

How I did it

How to verify it

Checklist

  • [x] Passes all linting checks (pre-commit and CI jobs)
  • [x] New test cases have been added and are passing
  • [x] Documentation has been updated
  • [x] PR title follows Conventional Commit standard (will be automatically included in the changelog)

sreyemnayr avatar Mar 05 '24 17:03 sreyemnayr

Yes, this lgtm, the UI offers the same so it makes sense.

antazoey avatar Mar 08 '24 23:03 antazoey

@sreyemnayr is there anything you need to get this across the line?

mikeshultz avatar Mar 29 '24 19:03 mikeshultz

Just time and a nudge 😄 will try to get it tomorrow!

On Fri, Mar 29, 2024 at 2:02 PM Mike Shultz @.***> wrote:

@sreyemnayr https://github.com/sreyemnayr is there anything you need to get this across the line?

— Reply to this email directly, view it on GitHub https://github.com/ApeWorX/ape-etherscan/pull/118#issuecomment-2027624567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJQTVNBYALB5YKLYYA3TLY2W3FNAVCNFSM6AAAAABEHQXELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGYZDINJWG4 . You are receiving this because you were mentioned.Message ID: @.***>

sreyemnayr avatar Mar 29 '24 22:03 sreyemnayr

ah crap @antazoey, looks like plugins need the treatment of https://github.com/ApeWorX/ape/pull/2020 as well

fubuloubu avatar Apr 23 '24 15:04 fubuloubu

ah crap @antazoey, looks like plugins need the treatment of ApeWorX/ape#2020 as well

Yes, they do, everything does! It's horrendous. The issue has been open with Github for so long.

antazoey avatar Apr 23 '24 16:04 antazoey

ah crap @antazoey, looks like plugins need the treatment of ApeWorX/ape#2020 as well

here is this one: https://github.com/ApeWorX/ape-etherscan/pull/126 I am not going to fix all 300 of our python packages; we will just fix them as they come up.

antazoey avatar Apr 23 '24 16:04 antazoey

all test fixes here: https://github.com/ApeWorX/ape-etherscan/pull/127

antazoey avatar Apr 23 '24 17:04 antazoey

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

github-actions[bot] avatar May 24 '24 01:05 github-actions[bot]

Is there something else that needs doing now that the tests are fixed?

On Thu, May 23, 2024 at 8:47 PM github-actions[bot] < @.***> wrote:

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

— Reply to this email directly, view it on GitHub https://github.com/ApeWorX/ape-etherscan/pull/118#issuecomment-2128338500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJQTWVIIW2236J6PKPJ2LZD2L33AVCNFSM6AAAAABEHQXELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYGMZTQNJQGA . You are receiving this because you were mentioned.Message ID: @.***>

sreyemnayr avatar May 24 '24 02:05 sreyemnayr

@sreyemnayr sorry, missed your review request. Changes LGTM.

@antazoey looks like there's still some test issues here? We need to set an infura key for this repo?

mikeshultz avatar May 24 '24 18:05 mikeshultz

@antazoey looks like there's still some test issues here? We need to set an infura key for this repo?

New contributors don't have access to our secrets, so just need to check it out of band

fubuloubu avatar May 24 '24 22:05 fubuloubu

Confirmed tests pass, but I can't merge this because passing tests are required. @fubuloubu you want to merge this?

mikeshultz avatar May 25 '24 21:05 mikeshultz