AntennaPod icon indicating copy to clipboard operation
AntennaPod copied to clipboard

Option to change app language

Open ApostolosKourpadakis opened this issue 1 year ago • 4 comments

Checklist

  • [X] I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • [X] I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • [X] I will describe the problem with as much detail as possible.
  • [X] This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.2

Where did you get the app from

Google Play

Problem you may be having, or feature you want

So I use the application for about a month now and when I first downloaded I am pretty sure it was by default in English. When I opened again the app after some weeks, it had automatically changed to Greek. So I searched in the settings if there is an option to change languages but I couldn't find one. I think that this could be a great feature because not everyone that lives in a country (e.g. Greece) is familiar with the native language. If this feature already exists please let me know!

Suggested solution

No response

Screenshots / Drawings / Technical details

No response

ApostolosKourpadakis avatar Apr 19 '24 06:04 ApostolosKourpadakis

This was already requested in #113. I think, however, that things have changed since then. Android 13+ supports per-app language settings, which we can enable as follows: https://developer.android.com/guide/topics/resources/app-languages

For someone implementing this, first try the automatic version and see if it contains languages that we don't actually support. If that is the case, create a script to create the language config file from the list of actual AntennaPod languages (i18n/values directory)

not everyone that lives in a country (e.g. Greece) is familiar with the native language.

The language is not based on your location but on what language you select on the Android settings screen.

ByteHamster avatar Apr 19 '24 15:04 ByteHamster

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/implement-android-13-per-app-language-setting/2287/2

antennapod-bot avatar Apr 19 '24 21:04 antennapod-bot

If that is the case, create a script to create the language config file from the list of actual AntennaPod languages (i18n/values directory)

@ByteHamster You are suggesting to run the script on the device?

tonytamsf avatar Apr 21 '24 15:04 tonytamsf

No, my idea was to have a script that we can run as part of creating a new release. We already have a bunch of scripts there (contributors list, website languages, etc). However, if AGP's automatic detection works well for us, we do not need a script (and should not create one).

ByteHamster avatar Apr 21 '24 17:04 ByteHamster

I have made a suggestion for changing the language of the app. The change is very small as it goes the preferred way via the central Android system setting for per app languages.

Nymuxyzo avatar May 31 '24 14:05 Nymuxyzo

@andre-m-dev Thanks! Did you test if you can select languages that actually are not supported by AntennaPod? (E.g. we don't ship translations for Bulgarian if I'm not mistaken, so it shouldn't be selectable.)

keunes avatar May 31 '24 14:05 keunes

@keunes it seemed to me that only the languages that are maintained in the project were available for selection. According to the documentation, this is exactly how I understand it: https://developer.android.com/guide/topics/resources/app-languages#auto-localeconfig

Nymuxyzo avatar May 31 '24 15:05 Nymuxyzo

Nice. Thanks for confirming.

keunes avatar May 31 '24 16:05 keunes