ine-dl icon indicating copy to clipboard operation
ine-dl copied to clipboard

Docker!

Open OisinHick opened this issue 1 year ago • 2 comments

I was attempting to make this run in a container on a VPS so I thought it might be a good idea to just submit my docker container file for anyone else who needs it! Best to leave it as it's own branch I think?

Changes

  • Added the docker file and slimmed down the readme and removed unnecessary info from the readme relating to this docker build

OisinHick avatar Aug 07 '24 13:08 OisinHick

Thanks but no docker volume mounts? Where would the courses be stored and retrieved from?

I'd also prefer keeping both the instructions for installing/using the script on a host machine and with separate instructions for the docker image and how to use it.

The commit also doesn't have aria2 installation which the script uses for downloading of files. Please fix that.

Anon-Exploiter avatar Aug 13 '24 00:08 Anon-Exploiter

Hey @Anon-Exploiter I added the changes and added the relevant run command for mount points onto the readme. Let me know if you want me to put in more info for users to get up and going. I designed this for my VPS originally

OisinHick avatar Aug 26 '24 04:08 OisinHick

changes look good, thanks for your contribution! Merged.

Anon-Exploiter avatar Dec 16 '24 00:12 Anon-Exploiter