angular-ru-sdk icon indicating copy to clipboard operation
angular-ru-sdk copied to clipboard

🐞 - `@angular-ru/ngxs` is not compatible with `@ngxs/store` `v18`

Open hakimio opened this issue 1 year ago • 5 comments

Which @angular-ru/* package(s) are the source of the bug?

ngxs

Is this a regression?

No

Description

Try to use @angular-ru/ngxs with the newly released @ngxs/store v18. Angular app compilation fails with the following errors:

X [ERROR] TS1238: Unable to resolve signature of class decorator when called as an expression.
  Type 'typeof CountryRepository' has no properties in common with type 'DataStateClass<any, any>'. [plugin angular-compiler]

    src/app/pages/countries/+state/country.repository.ts:8:1:
      8 │ @StateRepository()
        ╵  ~~~~~~~~~~~~~~~~~

hakimio avatar Jun 11 '24 06:06 hakimio

I don't have time to support that repository, sorry

splincode avatar Jun 11 '24 07:06 splincode

That's fine. I'll look into it when I have time.

hakimio avatar Jun 11 '24 07:06 hakimio

Thank you

splincode avatar Jun 11 '24 07:06 splincode

@splincode @Markiewic to make @angular-ru/ngxs compatible with @ngxs/store v18, I would need to update angular to v16. Is that ok?

hakimio avatar Jun 11 '24 07:06 hakimio

Sure, you can upgrade to Angular 16

splincode avatar Jun 11 '24 08:06 splincode

The new packages seem to be missing peer dependencies.

hakimio avatar Jul 12 '24 08:07 hakimio

fixed

splincode avatar Jul 12 '24 10:07 splincode

Shouldn't there also be some minimum requirement for Angular and related packages (forms, cdk, router, etc)? Is it Angular 16 or 18?

hakimio avatar Jul 12 '24 10:07 hakimio

I don't want to add this

splincode avatar Jul 12 '24 15:07 splincode