angular-ru-sdk icon indicating copy to clipboard operation
angular-ru-sdk copied to clipboard

862 persistence decorator in feature module fixed

Open yamaha252 opened this issue 3 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[*] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

@Persistence decorator not working in feature module

Issue Number: 862

What is the new behavior?

@Persistence decorator works in feature module

Does this PR introduce a breaking change?

[ ] Yes
[*] No

yamaha252 avatar Aug 09 '22 07:08 yamaha252

Codecov Report

Base: 82.64% // Head: 82.61% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (031cf92) compared to base (e7f777e). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 031cf92 differs from pull request most recent head fed58b5. Consider uploading reports for the commit fed58b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   82.64%   82.61%   -0.04%     
==========================================
  Files         617      617              
  Lines        8754     8756       +2     
  Branches     1679     1677       -2     
==========================================
- Hits         7235     7234       -1     
- Misses       1440     1442       +2     
- Partials       79       80       +1     
Flag Coverage Δ
cdk 80.11% <ø> (ø)
jest 80.83% <ø> (ø)
ngxs 96.41% <100.00%> (-0.22%) :arrow_down:
summary 82.61% <100.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ngxs/typings/src/storage/storage.ts 0.00% <ø> (ø)
...ibs/ngxs/decorators/src/persistence/persistence.ts 100.00% <100.00%> (ø)
libs/ngxs/internals/src/public_api.ts 100.00% <100.00%> (ø)
libs/ngxs/internals/src/storage/init-storage.ts 100.00% <100.00%> (ø)
...xs/storage/src/ngxs-data-storage-plugin.service.ts 99.33% <100.00%> (-0.03%) :arrow_down:
...xs/storage/src/utils/register-storage-providers.ts 87.50% <0.00%> (-12.50%) :arrow_down:
libs/ngxs/storage/src/utils/merge-options.ts 89.47% <0.00%> (-10.53%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 16 '22 01:08 codecov-commenter

Good job! So now I need fix release script in master branch and merge this branch later

splincode avatar Aug 21 '22 07:08 splincode