aero icon indicating copy to clipboard operation
aero copied to clipboard

aipc, an async ipc library for aero

Open pitust opened this issue 3 years ago • 2 comments

'nuff said.

pitust avatar Mar 19 '22 15:03 pitust

I'm not a fan of all these println!s polluting the stdout of the running process, even if they are unlikely to happen in most cases. You should return Results instead of printing the error and carrying on/signaling failure upstream. Also there is quite a few unwraps that could be turned into Results too.

48cf avatar Mar 19 '22 16:03 48cf

I'm not a fan of all these println!s polluting the stdout of the running process, even if they are unlikely to happen in most cases. You should return Results instead of printing the error and carrying on/signaling failure upstream. Also there is quite a few unwraps that could be turned into Results too.

I could possibly move them to sys_log, as not to pollute stdout. The majority of the errors shouldn't propagate above AsyncRuntime::run() anyway.

The unwraps are there because I explicitly wanted to prevent injecting Result, but if you have an idea how to make it work without destroying the ergonomics, please tell me!

pitust avatar Mar 19 '22 16:03 pitust