Instagram-for-PHP 5.5+ Laravel auto-discovery

5.5+ Laravel auto-discovery

Open s1rc opened this issue 7 years ago • 3 comments

Feb 13 '18 17:02 s1rc

Thanks for PR. Could you improve formatting? Also, please, could you share some info related to "auto-discovery" feature? Thanks!

Feb 13 '18 23:02 Andreyco

Fixed the formatting, weird that it didn't show like that on my editor.

With Laravel Auto-Discovery you don't have to register the Service Provider. So Laravel >= 5.5.x you do not need:

'providers' => array(
    // ...
    Andreyco\Instagram\Support\Laravel\ServiceProvider\Instagram::class,
    // ...
),

You still need to register the Facade alias if you plan on using it.

Feb 14 '18 00:02 s1rc

Any chance you will approve this PR?

Mar 07 '18 22:03 s1rc