Andrew Radev

Results 225 comments of Andrew Radev

I'm going to reopen this issue, because I've run into a bit of a problem. Issue #48 illustrates it. The problem is that the ternary pattern is _very_ broad and...

Being directly on the `?` might be a bit tricky, it _is_ just one character. Splitting the ternary if we don't have braces sounds a bit iffy. What if there...

Good catch, I try to handle comments when I can (in ruby in particular), but there was a subtle bug in this case. I've pushed a fix to master. Could...

There's no perfect solution here, I think. This isn't a new issue: https://github.com/AndrewRadev/splitjoin.vim/issues/31 My thinking is that, regardless of whether that comment is used to describe something in the middle,...

> Also, I believe inherently this plugin should have this property(reversible) That's not true, though. I mean, it already doesn't. For starters, trailing commas can get added or removed, depending...

An interesting idea. It feels like most operations that take a count work on a single line by default, and the count "increases" their effect. In this case, it'd be...

This is not going to be difficult, but I'm a bit worried about the curly brackets. I guess that, in both languages, both formats are acceptable: ``` javascript if (something)...

@MeanEYE The idea for the options sounds great! I hadn't thought of that at all. I hope people aren't confused by it, but I think it won't be a big...

Oops, my bad. Should be fixed now.

@MeanEYE, are you sure that you're setting the right variable? There are two of them, one for PHP and one for javascript: ``` vim let g:splitjoin_php_if_clause_curly_braces = 'sj' let g:splitjoin_javascript_if_clause_curly_braces...