Andrew Radev

Results 225 comments of Andrew Radev

The indenting thing is a tricky issue. In general, there are two styles that eruby is mostly able to handle: ``` eruby ``` The mixture of the two doesn't work...

@kballenegger, I've pushed a commit that should fix this issue, could you take a look and let me know if that's the case?

I wasn't aware, no. My comment in #249 is regarding the `let g:ruby_begin_continuation_style = "blah"` proposal. These two potential problems that you've discovered don't seem to be related to the...

Okay, this is weird. Here's how vim-ruby currently indents this case: ``` ruby one. three do "four" end # but, one. two. three do "four" end ``` The indenting of...

Yeah, both the first and the third example indent correctly, and those are the ones I'd prefer. It's the second example that's the tricky one. I agree that this looks...

@tpope Can you think of what case is being handled by this code? https://github.com/vim-ruby/vim-ruby/blob/4788a08433c3c90e131fc7d110d82577e1234a86/indent/eruby.vim#L97-L100 I get the meaning, it doesn't start with a ``, but I'm not sure what its...

Oddly enough, for me it's the other way around, sort of. With the plugin you link to, the "data-user" renders correctly, both in erb and html, as `htmlArg`. Without it,...

Hm, that's interesting. I wonder if that doesn't override eruby syntax somehow. Well, either way, does that mean this issue can be closed?

The relevant code seems to be this: https://github.com/vim-ruby/vim-ruby/blob/fix-closing-bracket-bug/indent/ruby.vim#L518-524. The problem is that the indent script takes the closing bracket, finds its opening one and indents to that. I suppose it...

Yes, I also noticed that. I'll see what I can do about it as well.