ampersand-magento2-upgrade-patch-helper icon indicating copy to clipboard operation
ampersand-magento2-upgrade-patch-helper copied to clipboard

Extended requirejs-config.js files don't seem to get detected, but not entirely sure if they should?

Open hostep opened this issue 6 years ago • 1 comments
trafficstars

This happens both on the master and fix-template-detection-issue-1 branches. Tested when comparing Magento 2.2.0 to 2.2.7

I'm not sure how important it is to report this, because I don't think you should mess with the default contents of these files, since it's supposed to be extended, but maybe people actually do overrides in these files.

So, if you have the following file in your frontend theme: app/design/frontend/Vendor/theme/Magento_Catalog/requirejs-config.js, it gets merged with vendor/magento/module-catalog/view/frontend/requirejs-config.js I think.

Right now this isn't reported, but I'm not entirely sure if it should be reported, it could be that just any requirejs-config.js files are all merged together and it probably doesn't matter in what modules they live. So not sure if it should get reported?

Update: I just saw in the code that this is actually still under investigation

hostep avatar Dec 05 '18 17:12 hostep

Hey @hostep, I'm going to try and be a bit more active on Ampersands public repos and try and sort through the backlog. Is this still an issue? Thanks

tr33m4n avatar Feb 09 '24 21:02 tr33m4n