AmmyUI icon indicating copy to clipboard operation
AmmyUI copied to clipboard

Don't add `lib.ammy` to main project

Open ionoy opened this issue 8 years ago • 2 comments

The idea is to link lib.ammy without referencing it in the main project. The navigation (F12 or Ctrl+Click) would still work.

ionoy avatar Mar 08 '17 09:03 ionoy

That's the idea I has proposed a month ago and there are my thoughts backing it:

  1. Lib.ammy was conceived as kind of BCL - it should provide common set of Ammy aliases and mixins. There is no point of modifying it by user - he could always create a new ammy-file with his own mixins. He could also add that ammy file as an "existing item" (linked file) to other projects. All the new aliases and mixins suggestions could be posted here in Github for including in Lib.ammy.
  2. Currently Lib.ammy is added into the root of the project during the nuget installation. If user moved it away, a new Lib.ammy will be added during nuget update and user will have MSBuild errors because there are two Lib.ammy files with the same aliases and mixins defined.
  3. Also Lib.ammy is overwritten during nuget update, potentially loosing changes done by user. Moving Lib.ammy away from the project will prevent user from editing it. Otherwise it's simply not safe to force Lib.ammy overwriting, but keeping old file is also not a good idea.
  4. Having some enforced file in the root of the project is not a good idea. In my particular case, all the markup files are go into UI subfolder. But currently Ammy enforcing Lib.ammy adding into the root folder of the project. It leads to the issue described at point 2.

@ionoy

The navigation (F12 or Ctrl+Click) would still work.

Very good! But you will need to mark file as read only as well, and add comment header that "this file is not editable because...".

Regards!

aienabled avatar Mar 09 '17 05:03 aienabled

+1 to this. Should I be adding it to my .gitignore in the meantime?

ashelleyPurdue avatar Feb 24 '19 20:02 ashelleyPurdue