workflow-controller icon indicating copy to clipboard operation
workflow-controller copied to clipboard

Published 20 hours ago • verified publisher icon AmadeusITGroup

Workflow with FAILED status

Open alexei-led opened this issue 8 years ago • 3 comments
trafficstars

Currently, Workflow can have one of two possible statuses:

  1. WorkflowComplete - when all its steps are completed
  2. WorkflowFailed - when "Deadline" is exceeded

IMHO, it should be failed also when one of workflow steps fails (Job fails).

alexei-led avatar Nov 05 '17 14:11 alexei-led

Yeah, in general, I concur. Problem is what are we going to do when a Job failed?

  1. Should we implement a retry policy? I think we should.
  2. When a job failed should we stop all the workflow? I think we should
  3. Remove the all the workflows? I think we should not.

Thoughts? @clamoriniere1A: ideas?

sdminonne avatar Nov 06 '17 09:11 sdminonne

@sdminonne when Job fail, after backoffLimit retries, we can stop the Workflow (if a user wants to, by specifying some tag). And I think we should not remove the failed workflow, user can do it later if wants to. Keeping workflow generated jobs/pods will allow inspecting "Failure" and maybe "fixing" workflow for next run.

alexei-led avatar Nov 06 '17 09:11 alexei-led

@alexei-led agree. Need to put together a proposal for the tags.

sdminonne avatar Nov 06 '17 09:11 sdminonne