workflow-controller icon indicating copy to clipboard operation
workflow-controller copied to clipboard

Docker multistage build

Open alexei-led opened this issue 8 years ago • 3 comments
trafficstars

Hi, guys

This is just a proposal: use Docker multistage build

This will enable to:

  • get a portable and repeatable build and test environment
  • build the project on any machine without a need to install and configure Go SDK (need Docker only)
  • easy switch to any CI (use even DockerHub automated build)

just one command to build docker build (or make container)

alexei-led avatar Oct 23 '17 12:10 alexei-led

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    23.4%   23.4%           
======================================
  Files           8       8           
  Lines         833     833           
======================================
  Hits          195     195           
  Misses        623     623           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0f1b6b...1af5fba. Read the comment docs.

codecov-io avatar Oct 23 '17 14:10 codecov-io

Thanks for your contribution and your time on this.

Believe me @alexei-led I see the value, just docker on my laptop is too old (even on updated fedora). Mind build the multistage in a docker or wait few weeks (to me to rework this, or simply moving to next fedora beta)?

sdminonne avatar Oct 23 '17 20:10 sdminonne

@sdminonne whenever you are ready

alexei-led avatar Oct 24 '17 06:10 alexei-led