Altonss

Results 371 comments of Altonss

I must have done something wrong, but now the tests are failing :( ping @TheLastProject

> I found the reason behind a few of the failing tests. Not all yet, there's some database constraint that are failing. Need to look at that still. Thanks a...

It fails to build because of some error in the strings translation it seems...

I don't know about this feature, but maybe it's not really needed? Like it's a one-time action a user can do manually if he wants to archive an empty gift...

Ah ok I understand. But I don't really know how to write the "if this is opened from the group widget" logic... I'm new to android development :)

It works now on my device! Feel free to make a review or propose some changes. As I'm new to android development, don't hesitate to make suggestions/corrections/bug reports !

I noticed a bug: when changing a group name after a widget has been created for this group, the widget doesn't work anymore. At least like for the cards, the...

I just added the following: an error message now appears if the group name has changed or has been deleted. That's the best thing I could do for this case...

> Please don't edit the MainActivity to also list groups, it complicates the code a lot and makes it hard to maintain. Well I didn't modify MainActivity to also list...

I simplified MainActivity. For the group selection code complexity, > You code is honestly overly complex and given how simple selecting a group is, you could use Android's built-in `android.R.layout.simple_list_item_2`...