vscode-dbt-power-user icon indicating copy to clipboard operation
vscode-dbt-power-user copied to clipboard

Remove deprecated apis

Open mdesmet opened this issue 1 year ago • 2 comments

Overview

Problem

Describe the problem you are solving. Mention the ticket/issue if applicable.

Solution

Describe the implemented solution. Add external references if needed.

Screenshot/Demo

A picture is worth a thousand words. Please highlight the changes if applicable.

How to test

  • Steps to be followed to verify the solution or code changes
  • Mention if there is any settings configuration added/changed/deleted

Checklist

  • [ ] I have run this code and it appears to resolve the stated issue
  • [ ] README.md updated and added information about my change

:rocket: This description was created by Ellipsis for commit 8eab166a494b0090d0a99d952d96066efe1d14b9

refactor: remove deprecated Python environment API usage

Summary:

Remove deprecated Python environment API usage by commenting out Python 3 checks and logging in VSCodeCommands, DBTClient, and PythonEnvironment.

Key points:

  • Behavior:
    • Commented out code in VSCodeCommands and DBTClient that logs Python paths and checks for Python 3.
    • Removed allPythonPaths and isPython3 properties from PythonEnvironment.
  • Files Affected:
    • index.ts in commands: Commented out logging of Python paths.
    • index.ts in dbt_client: Commented out Python 3 check.
    • pythonEnvironment.ts: Removed allPythonPaths and isPython3 properties.

Generated with :heart: by ellipsis.dev

Summary by CodeRabbit

  • Bug Fixes

    • Disabled logging of Python paths to enhance security by preventing sensitive information from being printed.
    • Simplified error handling by removing the check for Python 3 interpreter compatibility, allowing for smoother operation but potentially omitting important user prompts.
  • Refactor

    • Streamlined the PythonEnvironment class by removing unused properties and simplifying the constructor, focusing functionality on the dbtTerminal.

mdesmet avatar Sep 16 '24 21:09 mdesmet