Reusable icon indicating copy to clipboard operation
Reusable copied to clipboard

Support for NSTableView/NSCollectionView?

Open arthurhammer opened this issue 9 years ago • 5 comments

Are there any intentions to extend Reusable to macOS, specifically NSTableView/NSCollectionView? The library is obviously focused on iOS/UIKit but I thought I'd still ask :). Thanks!

arthurhammer avatar Oct 12 '16 15:10 arthurhammer

I think that's totally feasible. I don't do any macOS development, but I'd gladly accept a PR if you want to add support to it (I'm guessing that the macOS version is probably gonna be very similar to the iOS version if the APIs are similar?).

If you are willing to do a PR to add that, I'd just advise you to wait a bit until I finish the Swift 3 migration (PR pending) and release a new major version, to start your PR from a clean codebase.

AliSoftware avatar Oct 12 '16 18:10 AliSoftware

There are a couple of differences but conceptually the APIs are very similar.

Sounds good. When the Swift 3 PR lands I'll try working on a PR!

On 12 October 2016 at 20:04:52, AliSoftware ([email protected]) wrote:

I think that's totally feasible. I don't do any macOS development, but I'd gladly accept a PR if you want to add support to it (I'm guessing that the macOS version is probably gonna be very similar to the iOS version if the APIs are similar?).

If you are willing to do a PR to add that, I'd just advise you to wait a bit until I finish the Swift 3 migration (PR pending) and release a new major version, to start your PR from a clean codebase.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AliSoftware/Reusable/issues/27#issuecomment-253290825, or mute the thread https://github.com/notifications/unsubscribe-auth/AET9AF1diQ10Ok7gOZsG23nXA_mOt4dTks5qzSFEgaJpZM4KU6Si .

arthurhammer avatar Oct 12 '16 18:10 arthurhammer

Swift 3 support has landed last week, time to work on that now 😄

AliSoftware avatar Nov 20 '16 17:11 AliSoftware

I know this is an old issue, but any plans to do it? 😀 I could use it in a macOS side project now.

igorkulman avatar Dec 19 '18 21:12 igorkulman

@arthurhammer any news on your side about if you think you could find some time to do a PR for it? Otherwise, @igorkulman don't hesitate to give it a try 🙌 (I don't use the macOS APIs so someone who actually uses them would probably be more suited to adapt the code for it :wink: )

AliSoftware avatar Dec 20 '18 15:12 AliSoftware