John Gardner

Results 271 comments of John Gardner
trafficstars

> I don't see anything weird in the XML format... It's mixing tabs and spaces for indentation, but other than that, I can't see anything wrong either... :confused:

IMHO, the `Missing include in grammar:` errors should be downgraded to warnings; or, at the very least, passed through a whitelist of manual approvals (similar to how we're whitelisting certain...

@lildude Could we downgrade _"Missing include in grammar:… the scope cannot be found"_ errors to build-time warnings, please? The scenario @eric-wieser described is far from an isolated case, or even...

First, please fill out the pull-request template. It's there for a reason. Second, a little background on what "Wonkey" is would be nice. I notice that you're adding `.wx` as...

> The reason this is an issue and not a PR is that I'm not aware of any TextMate grammars for either of them. I can write one for you,...

I've never seen [this syntax](https://github.com/bpruitt-goddard/vscode-mermaid-syntax-highlight/blob/7d71f36b01d62fd26610b32eab1e104971b9cbed/syntaxes/mermaid.tmLanguage.yaml#L6-L9) before. Is `!!import/deep` a YAML thing? ~~~yaml repository: mermaid: patterns: !!import/deep - diagrams/ ~~~ Doesn't look like a valid TextMate-compatible grammar to me. It might...

Want me to write one? I'm already halfway through taking apart Mermaid's own Monaco-based highlighter to see how it works. I've reduced it to a list of keywords and patterns,...

Track progress here: https://github.com/Alhadis/language-mermaid I'll submit a PR once I've finished splattering mermaids.

> Here is an example of a few modern syntaxes. expression comment, block comment, and symbol with parenthesis inside. @jcubic Are you sure this is standard Scheme syntax, and not...

How's it rank in terms of speed? Compared with the current Bayesian classifier, I mean.