Cascadia.jl icon indicating copy to clipboard operation
Cascadia.jl copied to clipboard

Update Cascading.jl

Open PyDataBlog opened this issue 4 years ago • 2 comments
trafficstars

Currently matchFirst function isn't exported and since this is a key extraction function commonly expected to be used, this function should be exported for ease of access. What do you think?

PyDataBlog avatar Jun 22 '21 10:06 PyDataBlog

Investigating why this function needs exporting, I realised, our usage here is slightly different from base.

I think matchfirst should just become Base.match. We do have a match function, but that behaves differently from how base sees that function. I think we should lean in to base, and make matchfirst become match.

What do you think?

aviks avatar Jun 24 '21 10:06 aviks

I think leaning on base is the right choice too.

PyDataBlog avatar Jul 10 '21 07:07 PyDataBlog