Alex X

Results 2800 comments of Alex X

I'm not sure your TLV changes don't break anything.

Oh, great. I wrote that code completely blind. Just on a guess as to how it should work.

@los93sol 1. I have not seen any cameras that have a different CameraRTPStreamManagement. Can you send me the response from the camera? Preferably in raw JSON format. 2. Resolution is...

Apple uses non standard OPUS format. You can't use it anywhere without fixing.

Maybe this will helps you https://github.com/AlexxIT/go2rtc/blob/master/pkg/opus/homekit.go

I don't understand what part of the code you are referring to.

We set these values when we set up the connection. I don't see why they need to be changed. https://github.com/AlexxIT/go2rtc/blob/5cafc05e130f279a48b46411868ec92567963a86/pkg/homekit/consumer.go#L82-L127

Sorry, haven't had time to look into this PR yet.

In the queue https://github.com/AlexxIT/go2rtc/pulls/assigned/AlexxIT

Some remarks: 1. Your version of reading TLV has cleared all errors about invalid data. I suppose you could remove the `t==0` check here: https://github.com/AlexxIT/go2rtc/blob/4897994b35117d1cad886858b408518e8952e47a/pkg/hap/tlv8/tlv8.go#L196 2. You're using the opus...