Waybar icon indicating copy to clipboard operation
Waybar copied to clipboard

add format-icons to river/layout

Open AtomToast opened this issue 1 year ago • 5 comments
trafficstars

This PR enables the definition of format-icons to let you show an icon instead of the layout name. Default behaviour stays the same.

AtomToast avatar May 29 '24 15:05 AtomToast

@Alexays Sorry for the ping but is there any chance of this getting a review? I've been running this patch for the last few months and it's been working well for me

AtomToast avatar Sep 25 '24 15:09 AtomToast

@AtomToast Hello, thanks for the patch. Not sure if this is a waybar thing or something the patch has not addressed but when switching to a tags like this:

riverctl set-focused-tags 2

If "2" is empty and 1 is in monocle, the display remains as the square I used: 🔳

This is my config:

{
  "modules-left": ["river/tags","river/layout"],
  "river/tags": {
    "num-tags": 6,
    "tag-labels": [
      "",
      "",
      "",
      "",
      "",
      ""
      // "󰑴"
    ],
    "disable-click": false
  },
  "river/window": {
    "format": " {} ",
    "max-length": 98,
    "tooltip": true
  },
  "river/mode": {
    "format": "mode: {}"
  },
    "river/layout": {
        "format": "{icon}",
        "min-length": 4,
        "align": "right",
        "format-icons": {
               "monocle":"🔳"
        }
    }
    //"custom/layout": {
    //    "format": "{}",
    //    "signal": 1,
    //    "exec": "~/.config/waybar/bin/river-info.sh"
    //}
}

I am using the latest rivercarro which contains the -per-tag which makes each view independent views. Commit: 2c83990c80fab29e942b783d7194b5cab13f745a

-❯ river -version
0.3.7
-❯ waybar --version
Waybar v0.11.0
-❯ rivercarro -version
0.6.0-dev.1+2c83990

rickswe avatar Feb 01 '25 20:02 rickswe

@rickalex21 this is unfortunately a known river limitiation atm: https://codeberg.org/river/river/issues/1002

It's also unlikely to change until this current rework of the layout protocol is done: https://codeberg.org/river/river/pulls/1100

AtomToast avatar Feb 02 '25 13:02 AtomToast

@AtomToast Ok, thanks. Not a big deal since it's only an issue when switching from a tag with views to an empty tag. The empty tag has the layout of the previous tag despite it being empty. It correctly assigns the layout once a view is opened in the empty tag.

rickswe avatar Feb 02 '25 15:02 rickswe

Works great for me, thanks

seeschloss avatar Jun 16 '25 09:06 seeschloss