AlexandreHT
AlexandreHT
Hi @vidyadharg, finally I have (finally) been able to play around your solution and there are some points I'd like to discuss further. # On context It's definitely what took...
Yes, ```emulate_alt_codes``` is activated (ALT-144 give ```É``` as expected) ALT-0192 gives ```À``` but it's only a workaround, since the standard Windows shortcut for À is ALT+183 on my French edition...
I'm closing this issue because it's old and I don't think either it should be included in the library.
@vidyadharg : #119 is merged, you can go on.
Hi @vidyadharg, I saw you closed the PR (which was almost finish if I remember well). Is it a mistake or do you not wish to continue this topic further?...
Though I have no knowledge of the context, I'll take @andkopp to the word ("_Errors raised by OData services are already written to the application log._") and consider this enhancement...
I agree on the principle but I think we should keep the I, S, W, E, A as aliases because these are messages parameters on their own. I'd be also...
I'm not sure what you're referring to for "consistent error handling with exception class"? I'd add: move the log entry manipulation to a separate functionnal class (cf. https://github.com/ABAP-Logger/ABAP-Logger/issues/67#issuecomment-738303553) (zcl_abap_logger_functions?) Which...
Ok. We'll just have to handle the case where the program tries to log an zcx_logger exception. Considering the fact that this repo is much smaller than abapgit, it seems...
> Ideally `zif_logger` shouldn't have anything to do with UI. So... I don't think methods like `display_fullscreen` should have a place here. Instead you could have, for example, `zif_logger_ui` implemented...