treemacs
treemacs copied to clipboard
Alexander-Miller
Very blurry image icons in Retina screen
See for example:
Presumably they are rendered as for a 96 dpi screen and then scaled up x 2.
I'm using emacs-28 branch built from source with svg support. (frame-scale-factor) is correctly reported as 2. My laptop is a MacBook Pro 2017.
Also reported to lsp-mode in https://github.com/emacs-lsp/lsp-mode/issues/3143
Most of treemacs' icons are 22x22 px sized pngs, so the blurriness is to be expected with such a scale factor.
Converting them to svgs has been on my nice-to-have list for a while now, but it'll take me a while.
Converting them to svgs has been on my nice-to-have list for a while now, but it'll take me a while.
What about using these ones https://github.com/microsoft/vscode-icons ?
Here is another bunch https://github.com/vscode-icons/vscode-icons.
Also it would be great if you worked together with the lsp guys (https://github.com/emacs-lsp/lsp-mode/issues/3143) and maybe company/company-box also. There are a number of problems making icons a PITA in emacs, including coordination issues.
- font icons have alignment issues, it seems impossible to get them 100% right.
- there is no svg set but emacs has already moved to compiling with svg support by default.
- inconsistent icons across projects (company, lsp, treemacs).
So you may agree on providing at least one svg icon set that is consistent across the board. I don't know if there are licensing issues with the vscode set but: it's pretty, it's svg and it's "coordinated" by default.
Thinking about it, I believe it would be better if this icon set were distributed as part of all-the-icons or other new "icon distro package" instead of duplicating and fragmenting it across many projects. Most icons have a clear meaning which will likely be enough to achieve consistency across projects without explicit coordination. This is similar to the situation with font icons right now except that they bring a host of alignment problems and that their semantics is not always clear (being a mishmash of icons not necessarily designed for programming environments) which doesn't favor consistency.
What about using these ones https://github.com/microsoft/vscode-icons
That's my plan. But that's still replacing about 200 individual icons, so it'll take me a while to catch em all.
Also it would be great if you worked together with the lsp guys
Already happening - just look at lsp-treemacs.
font icons have alignment issues
That's because font icons are annoying buggers that aren't monospaced. So your best bet is add a tab to them and hope that it'll mitigate the ugliness. Sometimes it works, and sometimes dired-mode has a default tab-width of 8.
Thinking about it, I believe it would be better if this icon set were distributed as part of all-the-icons or other new "icon distro package"
I had the same thought, but it'll have to wait. This nifty stale bot I have just installed reminded me of a bunch of old issues, some of which are up to two years old now. I want to work my way through the old stuff before I start a major undertaking like this.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity.
Stay alive!
Yes, but also fyi making stay-alive comments is no longer strictly necessary now. I've turned off the part of the bot where it closes tickets, it only acts as a reminder now.
This issue has been automatically marked as stale because it has not had recent activity.
This issue has been automatically marked as stale because it has not had recent activity.