Dmitry Zotov
Dmitry Zotov
PR looks very good, but missing tests. * for enums add `cockroachdb` in `enabledDrivers` section [here](https://github.com/typeorm/typeorm/blob/master/test/functional/database-schema/enums/enums.ts) and [here](https://github.com/typeorm/typeorm/blob/master/test/functional/database-schema/enums-array/enums-array.ts) (if enum arrays are supported by crdb) * for spatial types please...
closing as answered.
* Added `enum` type support (original PR was missing code for synchronization) and tests * Fixed issues with spatial types synchronization + tests * Added support for spatial indices +...
* added [GeoJSON types](https://github.com/typeorm/typeorm/blob/564df2c294ba912d00637a6abce3147c9b49e6f3/src/driver/types/GeoJsonTypes.ts) * updated [Spatial Columns](https://github.com/typeorm/typeorm/blob/b4e8daa0e63427677a60396842759e8fb5568bd9/docs/entities.md#spatial-columns) docs * resolved review suggestions
@DrewImm btw, you can use `package.json` to avoid writing generate command multiple times. For example: ```json "generateX": "typeorm migration:generate ./database/migrations/x -d ds-x.ts", "generateY": "typeorm migration:generate ./database/migrations/y -d ds-y.ts" ```
@strongpauly please update [Postgres column types](https://github.com/typeorm/typeorm/blob/master/test/functional/database-schema/column-types/postgres/column-types-postgres.ts) test with the new type to make sure synchronization works as expected
thank you for contribution!
Feel free to PR!
same issue on Mac: ``` node-pre-gyp http GET https://github.com/mattrglobal/node-bbs-signatures/releases/download/0.11.0/node-v93-darwin-x64.tar.gz node-pre-gyp http 404 https://github.com/mattrglobal/node-bbs-signatures/releases/download/0.11.0/node-v93-darwin-x64.tar.gz node-pre-gyp ERR! install error node-pre-gyp ERR! stack Error: 404 status code downloading tarball https://github.com/mattrglobal/node-bbs-signatures/releases/download/0.11.0/node-v93-darwin-x64.tar.gz ```
@felix-gohla can you merge the latest `master` changes to your branch? Hope it will fix CI issue.