snarkVM icon indicating copy to clipboard operation
snarkVM copied to clipboard

Deduplicate macro code in parameters

Open ljedrz opened this issue 3 years ago • 4 comments

While looking at the issue of parameters not downloading, I noticed that plenty of code is duplicated in the related macros, making it harder to analyze; it will also cause trouble if in the future something needs to be adjusted there and the dev doesn't know or forgets that there are two spots where the change needs to be made.

ljedrz avatar Sep 22 '22 11:09 ljedrz

Cc @julesdesmit, as I see your comments in this code.

ljedrz avatar Sep 22 '22 11:09 ljedrz

Cc https://github.com/AleoHQ/snarkVM/pull/1092 for the failed clippy job

ljedrz avatar Sep 22 '22 11:09 ljedrz

The parameters-related CI job failures seem to be unrelated, but it would be best to merge this change only once they can be downloaded again.

ljedrz avatar Sep 22 '22 11:09 ljedrz

Rebased.

ljedrz avatar Oct 03 '22 11:10 ljedrz