Alex Fernandez
Alex Fernandez
This issue was closed by https://github.com/pyvista/pyvista/pull/5959 Thanks for fixing it @ChristosT 🚀
Christos is currently working in improving interactive documentation plotters. Here is his PR in case you want to try it out: https://github.com/pyvista/pyvista/pull/4938
> `pyvista.DynamicScrapper` doesn't correctly render for PyMAPDL for now because: > > * [ ] there are different plots for 1 output and it's not yet accepted by the scrapper...
> @AlejandroFernandezLuces how are we doing with this? The package was open source released last week, there were some major changes so I'll have to readapt as soon as I...
Everything seems to be working fine except for the minimal test jobs. I'm not sure what's happening there, any insights @germa89? https://github.com/ansys/pymapdl/actions/runs/9481844411/job/26125469222 GitHubfeat: Adapt PyMAPDL to common plotter · ansys/pymapdl@f820825Pythonic...
All CI tests are passing now, should I worry about the patch coverage? I'm not sure if it makes much sense to test the few lines that are not covered.
@germa89 Did you have the chance to take a look at this PR?
> How's this going @AlejandroFernandezLuces @germa89? I did an important refactor of the PR to have a better integration of the visualization tool. This solved some of @germa89 comments. Right...
@germa89 Can you give a review again?
A side discussion, code is somewhat coupled with PyVista due to how the picker works in PyMAPDL. I would suggest refactoring the picking capabilites of PyMAPDL in a follow up...