vue-virtual-scroller icon indicating copy to clipboard operation
vue-virtual-scroller copied to clipboard

Published 20 hours ago • verified publisher icon Akryum

DynamicScroller should pass its own keyField prop to child RecycleScroller

Open nicooprat opened this issue 3 years ago • 2 comments
trafficstars

When using DynamicScroller, the keyField prop was ignored because it was manually set as its default value id here.

nicooprat avatar Jun 10 '22 09:06 nicooprat

Might need to bind the attribute for this one to work 😜

ryanpwaldon avatar Jun 30 '22 12:06 ryanpwaldon

That was fast. Not banking on a merge anytime soon tho 😆🤞

ryanpwaldon avatar Jul 02 '22 03:07 ryanpwaldon

I merged this PR too fast, it is expected that DynamicScroller hard code key-field to id.

I will revert this to fix #758

Akryum avatar Oct 18 '22 08:10 Akryum

Items passed from DynamicScroller to RecycleScroller are always of the shape { id, item, size }: https://github.com/Akryum/vue-virtual-scroller/blob/95b934a10343338d102324766e84036e06d9a6a6/packages/vue-virtual-scroller/src/components/DynamicScroller.vue#L115-L125

Akryum avatar Oct 18 '22 08:10 Akryum

This issue has resurfaced in version 2.0, perhaps requiring another round of fixes.

leochen-g avatar Sep 18 '23 09:09 leochen-g