Unable to upgrade the ACS commons from 5.7.0 to 6.0.14

[gokulse]

Required Information

• [ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.5, 6.5.17
• [ ] ACS AEM Commons Version: 6.0.14
• [ ] Reproducible on Latest? yes

Expected Behavior

Update POM .xml with new version maven build should get pass.

Actual Behavior

Maven build is failing in the core module with error as package com.adobe.acs.commons.forms.helpers.impl.synthetics does not exist

Steps to Reproduce

With new version of ACS commons 6.0.14, build the code with code which uses com.adobe.acs.commons.forms.helpers.impl.synthetics.SyntheticSlingHttpServletGetRequest

Links

SyntheticSlingHttpServletGetRequest request = new SyntheticSlingHttpServletGetRequest( new SyntheticSlingHttpServletGetRequest( new SyntheticSlingHttpServletGetRequest(new SyntheticSlingHttpServletGetRequest( new SyntheticSlingHttpServletGetRequest(slingHttpServletRequestWrapper)))));

[pijantkar]

Hi team, we are facing the same issue in AEM cloud service.

[2023/08/30 04:25:28.405] [ERROR] com.adobe.granite.fact.command.AnalyseCommand - Exception in analyser: Errors: [api-regions] Region 'global' defined in feature 'com.adobe.granite:aem-ethos-app-image:slingosgifeature:aem-runtime-application-author-dev:1.0.0-SNAPSHOT' declares 10 packages which are not exported by any bundle:

• com.adobe.acs.commons.components.longformtext
• com.adobe.acs.commons.designer
• com.adobe.acs.commons.forms
• com.adobe.acs.commons.forms.components
• com.adobe.acs.commons.forms.helpers
• com.adobe.acs.commons.quickly
• com.adobe.acs.commons.quickly.operations
• com.adobe.acs.commons.quickly.results
• com.adobe.acs.commons.widgets
• com.adobe.acs.commons.xss

[davidjgonzalez]

@pijantkar those were all removed from ACS Commons 6.x. If you need all those features, you'll need to stay on the latest ACS Commons 5.x release.

Also, im unclear how youre doing:

With new version of ACS commons 6.0.14, build the code with code which uses com.adobe.acs.commons.forms.helpers.impl.synthetics.SyntheticSlingHttpServletGetRequest

That class is in a private impl package and not exported, so im not sure how/why you'd be directly using that?

[pijantkar]

Hi @davidjgonzalez , Thanks for the quick response. FYI, we are using AEMaaCS. The pipeline fails when we add the dependency and embed the package as suggested in the documentation. https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html

The error log is from Cloud Manager dev pipeline. The pipeline fails due to the error. FYI - we are on below release on cloud.
AEM RELEASE: 2023.7.12874.20230726T072051Z

I am not sure if these above packages are not required in 6.0.14 version of ACS commons, then why cloud manager is looking for these packages?

[yomori0510]

Hi @gokulse @davidjgonzalez @pijantkar I suggest you all get together in a web call quickly to discuss. It will be faster to resolve this that way. ACS, please provide suggested time for a call. This Sony team is based in India mainly so their business hours would be better.

[gokulse]

anytime between 10 am to 5 pm IST will work for me

[pijantkar]

Hi @gokulse , @davidjgonzalez , I am also working in IST hours. Can we connect now?

[gokulse]

Hi @pijantkar ,

Can we schedule the call tomorrow ?

Please send the invite to [email protected]

Regards Gokul S

[yomori0510]

@pijantkar , Please organise a call with Sony's Gokul to discuss this matter today. Yoshie Mori (TAM)

[pijantkar]

Hi @gokulse , sorry, we could not connect today. Can we please let me know your convenient time to connect today?

[gokulse]

Hi @pijantkar ,

We can connect 5th Sep 2023 11:30 AM IST.

Regards Gokul S

[davidjgonzalez]

Hi, friendly reminder this is a community project (Adobe Community Software). If you want to engage with your Adobe Consulting team, you should do so with them directly. Adobe consulting does not monitor this GitHub and many/most participants do not work even for Adobe!

Sorry for any confusion!

[jeffreyvandenbossche]

Hi Maybe not 100% related to the context or the discussion but we are experiencing an issue while update from 5.7 to a 6.X version.

Build succeed (local as on AEM as a cloud service) but while checking the deployed packages/bundles I still see a reference to 5.7 instead of 6.X.

We don't have any reference in the code towards the 5.7 version. Anyone else experiencing the same issue or a solution how to fix this?

Thanks