acs-aem-commons icon indicating copy to clipboard operation
acs-aem-commons copied to clipboard

Providing a way to store SCP in experience fragments

Open Derthenier opened this issue 3 years ago • 4 comments

Enabling shared component nodes in experience fragment folder structure

Derthenier avatar Aug 09 '22 14:08 Derthenier

Codecov Report

Merging #2930 (dce9a00) into master (ce3787a) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2930   +/-   ##
=========================================
  Coverage     54.05%   54.05%           
  Complexity     5609     5609           
=========================================
  Files           756      756           
  Lines         30779    30779           
  Branches       3978     3978           
=========================================
  Hits          16637    16637           
  Misses        12594    12594           
  Partials       1548     1548           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 15:08 codecov[bot]

@Derthenier looks good - are there possibilities of conflicting w/ people that are already overlaying this space? Could we collide/overwrite with some else's customization?

davidjgonzalez avatar Aug 12 '22 19:08 davidjgonzalez

It is possible that it will create conflicts for people extending the experience fragments

Derthenier avatar Sep 16 '22 20:09 Derthenier

I wonder if we just package this up and link to it from the docs page?

davidjgonzalez avatar Sep 16 '22 21:09 davidjgonzalez