FiltersCompiler icon indicating copy to clipboard operation
FiltersCompiler copied to clipboard

Our current exclusion does not remove `! Redirect:` directive

Open zloyden opened this issue 3 years ago • 4 comments

To reproduce it:

  1. Add my filter via @include to any template of the filter. For instance, Dandelion Sprout Annoyances
@include "https://raw.githubusercontent.com/zloyden/fox/master/123.txt" /exclude="../../exclusions.txt"
  1. Run the filter build
  2. It does not work, but it should work due to exclusion Redirect:

Please also check that this Regex should also apply and remove the redirect directive.

zloyden avatar Jul 05 '22 11:07 zloyden

About regex - text /^\!\s*(R|r)edirect:/ without Redirect: and redirect:

Alex-302 avatar Jul 05 '22 11:07 Alex-302

Well, the proper reaction to redirect directive should be failing the build completely

ameshkov avatar Jul 06 '22 08:07 ameshkov

The point is that when this happens we should react accordingly and change the FiltersRegistry

ameshkov avatar Jul 06 '22 08:07 ameshkov

Should we revert https://github.com/AdguardTeam/FiltersRegistry/pull/638 and just remove redirect: exclusions?

Alex-302 avatar Jul 06 '22 14:07 Alex-302