AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

Handle the `ESC` key on the custom drop-down lists in `AdGuard Settings`

Open contribucious opened this issue 2 years ago • 3 comments

AdGuard Extension version

4.1.53

Browser version

Firefox 111.0.1

OS version

Windows 10 Pro 22H2 (OS Build 19045.2728)

Issue Details

Hi. Your custom drop-down lists don't handle the ESC key in AdGuard Settings (i.e. nothing happens when pressed). See screenshot n°1 and screenshot n°2 for two examples of these drop-down lists.

Expected Behavior

The ESC key is handled. Just like it is on a native drop-down list (test one here). Meaning, the custom drop-down list closes when this key is pressed.

Screenshots

Reveal …  

firefox_FmZQPR1iCJ

firefox_lRy5V1tdbv

contribucious avatar Mar 30 '23 21:03 contribucious

:bulb: Note: Also applies to the Settings page of the AdGuard VPN Browser extension product — see screenshot.

contribucious avatar Apr 15 '23 19:04 contribucious

💡 Note: Also applies to the Settings page of the AdGuard VPN Browser extension product — see screenshot.

It would be better to create the same issue in the corresponding repository.

maximtop avatar Apr 17 '23 06:04 maximtop

Indeed. 😉

↪️ Here we go: https://github.com/AdguardTeam/AdGuardVPNExtension/issues/90 :relaxed:

contribucious avatar Apr 17 '23 11:04 contribucious

Thanks for the report! This issue has been closed as it will be implemented as part of issue #3035. Please refer to that discussion for further updates.

kurrx avatar Mar 13 '25 08:03 kurrx