AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

Disable auto-enabling of a specific language filter

Open trmdi opened this issue 3 years ago • 12 comments

I'm using an external filter for the same language and I don't want the built-in one to be enabled automatically while still want that for other languages. The problem is the built-in one keeps being enabled whenever I disabled it.

trmdi avatar Jul 27 '22 11:07 trmdi

Hi, There is an option, which disables filters auto enabling. image

maximtop avatar Jul 27 '22 11:07 maximtop

Wait, doesn't it also disable all other languages? I'm asking about disabling just one language, while keeping it on for other ones.

trmdi avatar Jul 27 '22 12:07 trmdi

It will disable filters auto enabling for all languages. There is no other possibilities to solve your problem. There are two ways auto-enable filters or no.

maximtop avatar Jul 27 '22 12:07 maximtop

Could it work like this: by default, language-specific filters will be automatically activated like how it works currently, but once the user explicitly disables a language, it will never be automatically activated again.

trmdi avatar Jul 27 '22 13:07 trmdi

It is possible. We will consider implementations of this feature.

maximtop avatar Jul 27 '22 13:07 maximtop

Although it is not clear how to return filter to the state where you want it to be enabled again? What if some person accidentally or diliberately disabled filter and is not against filter to be enabled automatically?

maximtop avatar Jul 27 '22 13:07 maximtop

I think that result requires quite a lot of actions, so it couldn't be an accident, and that user definitely knows what he is doing and how to reenable it.

trmdi avatar Jul 27 '22 13:07 trmdi

one action doesn't look like quite a lot of actions but filters auto enabling for this filter would turn off implicitly and this may be a surprise for the user

maximtop avatar Jul 27 '22 15:07 maximtop

one action doesn't look like quite a lot of actions

To disable a language-specific filter, the user has to open Adguard settings (1) -> click on Filters (2) -> click on Language-specific (3) -> click on the Disable button to disable it (4). Sorry, maybe I meant this requires (4) steps, it can't be an accident.

but filters auto enabling for this filter would turn off implicitly and this may be a surprise for the user

sorry, I don't get this. Once the user disabled a filter, do you think he still wants to enable it automatically ?

trmdi avatar Jul 27 '22 16:07 trmdi

@Stillness-2 @maximtop Well, a feature request like this has already been opened, maybe it will be included in the future. You can check this: Disable unused language-specific filters

gork7777 avatar Jul 27 '22 16:07 gork7777

@trmdi you are right

maximtop avatar Jul 27 '22 17:07 maximtop

@gork7777 these features are not similar

maximtop avatar Jul 27 '22 17:07 maximtop

Hi, any news on this FR ?

trmdi avatar Apr 28 '23 09:04 trmdi

Hey @trmdi,

Just wanted to let you know that we haven't started working on this feature request yet since it's not a top priority right now. We know it matters to you and others, so we'll keep it on our radar for the future. Thanks for being patient with us!

maximtop avatar Apr 28 '23 09:04 maximtop

Closing this issue, since it is a duplicate of this one https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2122

maximtop avatar Sep 11 '23 16:09 maximtop