AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

`$subdocument,document` modifier doesn't work correctly if `iframe` exists

Open piquark6046 opened this issue 3 years ago • 2 comments

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [X] I am running the latest version
  • [X] I checked the documentation and found no answer
  • [X] I checked to make sure that this issue has not already been filed

Issue Details

  • AdGuard version:
    • 4.0.171
  • Browser and version:
    • Mozilla Firefox Dev 101.0b9
  • Operating system and version:
    • Ubuntu 22.04
  • Filters you use in AdGuard:
    • AdGuard TPF, AdGuard URL Tracking, AdGuard Social, AdGuard Annoyances and List-KR
  • Stealth Mode settings:
    • Disabled
  • Other browser extensions:
    • None

Expected Behavior

Blocks correctly the subdocument request without a redirection of AdGuard like uBO.

Actual Behavior

Blocks all HTML document request containing the targeted subdocument.

Screenshots

uBlock Origin 1.42.4

Screenshot from 2022-05-29 14-04-16 Screensho66

AdGuard Browser Extension

Screenshot from 2022-05-29 14-06-36

Additional Information

https://news.sbs.co.kr/news/endPage.do?news_id=N1006768033

||img.sbs.co.kr/news/ad/delay_redirect.html$subdocument,document
! ||img.sbs.co.kr/news/ad/delay_redirect.html$document
! ||img.sbs.co.kr/news/ad/delay_redirect.html$subdocument

piquark6046 avatar May 29 '22 14:05 piquark6046

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 31 '22 13:08 github-actions[bot]

Ping.

piquark6046 avatar Aug 31 '22 14:08 piquark6046

Ping.

piquark6046 avatar Oct 30 '22 14:10 piquark6046

https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2322

Alex-302 avatar Apr 06 '23 20:04 Alex-302

Can't reproduce with v4.2.159, seems to be resolved

maximtop avatar Aug 25 '23 15:08 maximtop

Cannot reproduce with v4.2.159. But, I can reproduce with v4.1.57.

piquark6046 avatar Aug 28 '23 11:08 piquark6046

v4.2.159-beta is already out

maximtop avatar Aug 28 '23 12:08 maximtop

https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2095#issuecomment-1695625590

That's just a comment left during communicating a Slack DM with @Alex-302.

piquark6046 avatar Aug 28 '23 12:08 piquark6046