Adaptive-Web-Components
Adaptive-Web-Components copied to clipboard
Initial support for style module media query variations
Pull Request
Description
Adding support for media query variations on style modules.
I put this in a feature branch so @khamudom can implement the high contrast styles.
Issues
Closes #89
Reviewer Notes
It was straightforward to add this functionality to Styles. I wanted to support Behavior closer, but Styles is intended to be an abstraction for it to work with tooling and other non-FASTElement components. This is potentially a grey area as hooking onto Styles provides a good place to do this, if it still makes sense that not everything conveyed in Styles is applicable for every potential output (like Figma).
Test Plan
We will need a full test pass of all components in Storybook.
Checklist
General
- [ ] I have included a change request file using $ npm run change
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the CONTRIBUTING documentation for this project.
Component-specific
- [ ] I have added a new component
- [ ] I have modified an existing component
⏭ Next Steps
Continue defining the forced colors high contrast styles.