gitlab-ce-ldap-sync icon indicating copy to clipboard operation
gitlab-ce-ldap-sync copied to clipboard

Published 20 hours ago • verified publisher icon Adambean

Users from the "userNamesToIgnore" list removed from their groups

Open vigen-b opened this issue 1 year ago • 2 comments

Hello and thanks for the helpful tool.

I'm not sure, but it seems to be a bug. When I add a user to the userNamesToIgnore list, he is removed from all groups. A little debugging shows that ignored users are not skipped in the deployGitlabUsersAndGroups method.

Particularly ignored users are not skipped in this snippet.

https://github.com/Adambean/gitlab-ce-ldap-sync/blob/fab2ace0071f12b95735baaa30bf141ce0226ff3/src/LdapSyncCommand.php#L1913-L1928

vigen-b avatar Dec 22 '23 16:12 vigen-b

@Adambean I tried to fix the bug. Can you take a look at the PR #41?

vigen-b avatar Dec 25 '23 10:12 vigen-b

Thanks for submitting a PR :) I'll look into this shortly.

Adambean avatar Dec 25 '23 13:12 Adambean