activitysim

activitysim copied to clipboard

Better feedback when file is missing from data_dir

1

`populationsim/example_test$ python run_populationsim.py -c configs2` ``` File "/usr/local/anaconda3/lib/python3.7/site-packages/activitysim-0.9.2-py3.7.egg/activitysim/core/config.py", line 267, in data_file_path return cascading_input_file_path(file_name, 'data_dir', mandatory) File "/usr/local/anaconda3/lib/python3.7/site-packages/activitysim-0.9.2-py3.7.egg/activitysim/core/config.py", line 260, in cascading_input_file_path (dir_list_injectable_name, file_path, dir_list)) RuntimeError: file_path data_dir: file 'None'...

blakerosenthal

Provide better feedback when output_dir not found

1

If output_dir is not found, output_dir method in core/config.py `raise RuntimeError("output_dir: directory does not exist")` resulting in the message: `RuntimeError: output_dir: directory does not exist` This is misleading because 'output_dir'...

toliwaga

Input data must not have empty cells

1

Empty cells in the landuse data caused the location choice models to not find any alternatives. Replacing the nulls with zero in the landuse data resolved the issue.

albabnoor

from @danielsclint - The example_manifest.yaml that downloads and sets up the example folders is hard coded to read from the “compiled” python egg. This doesn’t provide much flexibility to point...

bstabler

for easier distribution of examples. Copy the example notebooks from the package install location to the user specified folder created by the create command.

bstabler

store skims as scaled ints to decrease RAM needs?

1

@stefancoe - can we scale skims (e.g. multiply each one by 100) so that they can be stored in memory as integer instead of float, like DaySim does? This would...

bstabler

Checks for `sys.version_info < (3,)` are no longer necessary: https://github.com/ActivitySim/activitysim/blob/a3dca1f8280374cc3fa22aa27d0503a20f3bdf58/activitysim/core/config.py#L314 https://github.com/ActivitySim/activitysim/blob/a3dca1f8280374cc3fa22aa27d0503a20f3bdf58/activitysim/abm/tables/skims.py#L40 https://github.com/ActivitySim/activitysim/blob/a3dca1f8280374cc3fa22aa27d0503a20f3bdf58/activitysim/core/steps/output.py#L43 We can also consider updating our string interpolation convention to use the more readable 'fstring' format, only in...

blakerosenthal

Ideally Phase 5 Task 4 will include the ability to export / output decisions that are determined internally that may not be getting saved currently. Examples of valuable information that...

bettinardi

We test on Linux and I typically also test on my Windows laptop and/or our Windows servers. We should build this into the build script since [Travis supports Windows](https://docs.travis-ci.com/user/reference/windows/) as...

bstabler

TM1 allows for not shadow pricing the grade school segment. We should add the ability to not shadow price certain segments or maybe set a max iterations by segment?

bstabler