activitysim
activitysim copied to clipboard
ActivitySim
Make sharrow work for school escorting
- [x] don't crash on Sharrow-test
- [ ] pass sharrow-test
- [ ] remove string comparisons
Just wanted to make sure you knew that the string removal work was performed already here: https://github.com/ActivitySim/activitysim-prototype-mtc/pull/4
@dhensle you make a good point. Also, while I'm pushing fastmath through all the components, I realized its convenient to wrap all component level sharrow controls together (i.e., also skip) to ensure a consistent user interface.
@dhensle this PR is ready for your re-review. I believe I addressed your concerns, and then some.
In thinking about the solution for #842, I realized we probably want these controls to be more general that "sharrow_settings", something more like "compute_settings". The reason we are seeing the overflow in #842 seems to be because we are using bottleneck for the computations, but if we activate compute.use_numexpr instead the problem goes away. If we make these controls more general, we can trigger this pandas setting here as well. This allows us to change compute settings in a consistent component-specific manner for non-sharrow compute. For now, that includes settings the pandas options compute.use_bottleneck, compute.use_numexpr, and compute.use_numba (see pandas.set_option).
@dhensle Will you have time to finish a (re)review of this PR this morning so we can merge it? It is now blocking progress on #833 as we want to coordinate the settings.