activitysim icon indicating copy to clipboard operation
activitysim copied to clipboard

Double check Sharrow memory usage fix (#751) is merged and implemented

Open i-am-sijia opened this issue 1 year ago • 0 comments

Describe the bug In Phase 8, we identified a memory usage issue in Sharrow. It was holding onto Sharrow flow data from already completed simulations. This was revealed when we compared the memory foot print of mandatory tour scheduling model of runs with vs without Sharrow. In between the simulation of tour scheduling segments (i.e., work, school, univ), the non-Sharrow run had memory released and restart from a low "base" point but the Sharrow run did not release memory and it piled up.

This was fixed in PR #751 . And at the end of the data type optimization work in Phase 8, the profiling result showed it worked. See documentation here -> https://github.com/ActivitySim/activitysim/issues/673.

In the most recent benchmarking run, it seems the memory of the mandatory tour scheduling is piling up again, in between its segments, and also impacting the starting point of school escorting.

image

Zoomed in on Mandatory Tour Scheduling:

Non-sharrow: image

Sharrow: image

i-am-sijia avatar Feb 22 '24 23:02 i-am-sijia