krita-ai-diffusion
krita-ai-diffusion copied to clipboard
Feature Request: Make Prompt Parameter in Custom Workflows more usable.
I really like the new custom workflows feature. Amazing work as always!
But prompt parameter node can be made way more usable if it outputs not only text, but also includes loras that in the prompt (it already has loras autocompletion in this field).
I see it like this. There is a new node that has three inputs: model, clip and text append (because we need to append prompts from Krita Style node) and output something like MODEL, CLIP, and STRING of text without lora tags.
Also it would be super amazing if it syncs prompt values with other modes like Generate, Live, Animation.
Thanks!
P.S. Or maybe just a checkbox in Krita Style node (prompt inputs: true/false), and no need for a new node
A Style node have prompt outputs which is useless now, it would be good if this node came with a prompt window as in normal mode.
Something like this:
it would be good if this node came with a prompt window as in normal mode.
Yes, I like the idea
The positive/negative outputs of the style nodes are the templates configured in the style. You can merge them with an actual prompt from a separate parameter, or ignore them, or merge them and pass them to some other encoder, or a wildcard node, or some LLM, etc. - before you CLIP encode them.
The main purpose is to give full control & flexibility, so I think the current behavior is fine. It might make sense to offer some high level nodes for convenience. But they'd likely duplicate some functionality that already exists in Comfy or other custom nodes.
The main purpose is to give full control & flexibility, so I think the current behavior is fine. It might make sense to offer some high level nodes for convenience. But they'd likely duplicate some functionality that already exists in Comfy or other custom nodes.
You are absolutely right.
But I really like the convenience of your innovative plugin.
As an example I have a custom workflow where I can upscale image to 4k or maybe 8k with an upscaler and then Tiled Diffusion with control net. It would be useful if prompts is synced with Generate Mode. You can just switch to custom workflow any time and hit generate to get 8k. No need to copy-paste prompts.
And by the way you have custom lora paths searching code. I have to modify LoRA Tag Loader for ComfyUI extension to get similar behavior of inserting loras from text prompt.
So it would be nice if
- Syncing prompts between modes
- Loading loras from prompt identically as in other modes.
Thanks. Your work is really top notch.