comfyui-tooling-nodes icon indicating copy to clipboard operation
comfyui-tooling-nodes copied to clipboard

Parameter nodes demand min/max inputs to be filled if being run from within ComfyUI for parameter types that don't have min/max inputs

Open ArgentVASIMR opened this issue 5 months ago • 6 comments

I encountered this behaviour on my own personal workflow when the offending nodes were made to interact with an if-else node. They refused to allow the if-else to run, despite the if-else in question being set on an option that wouldn't let the offending nodes run anyway:

got prompt
Failed to validate prompt for output 162:
* ETN_Parameter 33:
  - Required input is missing: max
  - Required input is missing: min
Output will be ignored
Failed to validate prompt for output 165:
* ETN_Parameter 131:
  - Required input is missing: max
  - Required input is missing: min
* ETN_Parameter 67:
  - Required input is missing: max
  - Required input is missing: min
* ETN_Parameter 119:
  - Required input is missing: max
  - Required input is missing: min
* ETN_Parameter 155:
  - Required input is missing: max
  - Required input is missing: min
Output will be ignored
Failed to validate prompt for output 32:
Output will be ignored
Failed to validate prompt for output 161:
Output will be ignored
Failed to validate prompt for output 164:
Output will be ignored
Failed to validate prompt for output 159:
Output will be ignored
Failed to validate prompt for output 23:
Output will be ignored
Failed to validate prompt for output 169:
Output will be ignored
# of Detected SEGS: 1
Prompt executed in 0.20 seconds

The affected nodes are of types text, prompt, toggle, and choice, all of which have no "min" or "max" values inputtable. Any parameter node of type "number" or "number (int)" ran successfully with no errors.

Another friend of mine ran the same workflow I did and did not encounter this issue, despite sharing the same versions as I do on everything. I am on the latest versions of ComfyUI and comfyui-tooling-nodes.

edit: Two major differences are that the friend is running portable ComfyUI on Windows, while I'm running venv ComfyUI on Linux.

ArgentVASIMR avatar Jun 11 '25 00:06 ArgentVASIMR

Update: I have fully reinstalled ComfyUI, fully reinstalled comfyui-tooling-nodes, and the issue persists for me. Another friend of mine running Linux has not encountered the issue.

That friend is on PopOS, I am on Mint. Both are Ubuntu-based.

Update 2: Another friend ran it on Windows, and encountered the same error I did.

ArgentVASIMR avatar Jun 12 '25 03:06 ArgentVASIMR

Update 3: Turns out this is a ComfyUI manager issue! I am currently diagnosing the issue and figuring this out.

ArgentVASIMR avatar Jun 13 '25 08:06 ArgentVASIMR

Here is a copy of the extension that ComfyUI Manager installed, copied from my own ComfyUI install: comfyui-tooling-nodes-argent.zip

For krita.py, it differs in the following line between broken and working:

Broken:

    def placeholder(self, name: str, type: str, default, min, max):
        return (default,)

Working:

    def placeholder(self, name: str, type: str, default, min=0.0, max=1.0):
        if type == "number":
            return (float(default),)
        elif type == "number (integer)":
            return (int(default),)
        return (default,)

It's almost as if ComfyUI Manager is deciding to install an earlier version of the extension instead of latest, despite claiming it's the latest.

ArgentVASIMR avatar Jun 13 '25 09:06 ArgentVASIMR

I think "latest" in ComfyUI manager means latest official release of the nodes. There is also a "nightly" option in ComfyUI Manager, which pulls the latest git state.

The release can be a bit behind, I don't always make a new one when fixing minor things. Though maybe this issue is more wide-spread than I thought

Acly avatar Jun 13 '25 09:06 Acly

Hi, thanks for getting back to me! Just tested reinstalling the "Nightly" version, and it works!

When was the commit for ComfyUI Manager's "Latest" version of comfyui-tooling-nodes (2.0.2)?

ArgentVASIMR avatar Jun 13 '25 09:06 ArgentVASIMR

You can see the history here: https://github.com/Acly/comfyui-tooling-nodes/commits/main/

It was before https://github.com/Acly/comfyui-tooling-nodes/commit/696899a5fcd184f6e2e06ae67aa05b6baed9e0d0 which probably fixed the issue you encountered.

Acly avatar Jun 13 '25 10:06 Acly