adop-platform-management icon indicating copy to clipboard operation
adop-platform-management copied to clipboard

Cartridge Loader should allow generic Key Value pair params

Open luismsousa opened this issue 8 years ago • 3 comments

ENHANCEMENT: As a Jenkins developer, I want to load a cartridge collection and have it receive a Key-value pair map that will be passed on to each loaded cartridge in the collection.

Currently, the Cartridge loader receives a JSON payload specifying the cartridge URLs and the Folder names.

The proposed is to add either an extended choice or multi-line string parameter to inject collection params at load time. This would allow for example to load a set of cartridges for a specific target environment.

luismsousa avatar Mar 21 '17 11:03 luismsousa

Somewhat scary, as I had practically the same idea last night - great minds?

Griffin, Nicholas·9:37 AM

Here's a crazy idea I had very late last night: Load_Cartridge has a multi-line string field called something fun like "EXTRA_PROPS" which takes in K=V pairs First step of the job parses that field, throws errors if there's any form of problem with the data, then allows it to be injected into the build as environment variables Cartridges can then provide the ability to provide their own values that you can override, for example we might have a "standard" one called "PRIMARY_REPO" that if set lets you override what to point the build job at Going up an extra level, a cartridge collection could also pass these values in - turning it into a better manifest for generating batches of jobs

nickdgriffin avatar Mar 21 '17 11:03 nickdgriffin

spooky 😃 Here's what we're proposing, new stuff in blue. Diagram

luismsousa avatar Mar 21 '17 12:03 luismsousa

@dsingh07 @nickdgriffin will this be covered by custom cartridge properties?

RobertNorthard avatar May 11 '18 13:05 RobertNorthard