openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Added VDB Point Support to vdb_print - #617

Open kaarrot opened this issue 5 years ago • 6 comments

Supported for ABI >= 6

  • total/active/inactive point count
  • attribute name, type, uniform, index, flags, compression
  • group name and count information
  • whether the descriptor is shared - needs to be verified if I got it right. :)

Signed-off-by: kuba [email protected]

kaarrot avatar Feb 26 '20 19:02 kaarrot

CLA Check
The committers are authorized under a signed CLA.

  • :white_check_mark: kubaroth (a254cdb94b5551c10ca3156e06245c29873d5765)

Thanks Kuba! :)

I actually have a new convenience class coming (AttributeSet::Info) that I hope will help to alleviate some of the extra work you've had to do here. It's an issue that comes up quite frequently - there's some metadata stored with the AttributeSet/Descriptor (order of arrays, groups, etc) and some with the AttributeArray itself (is the array uniform, hidden, etc) and to get a complete picture of the data being stored you have to deal with both layers.

In attempting to introduce logic to cleanly merge multiple differing AttributeSets/Descriptors, a new convenience abstraction seemed to be a good place to put this. I'm aiming to share a version (without the merging functionality) before the end of the week so it would be good to see if this makes the code here simpler.

(In the meantime, it would still be worth getting the CLA resolved)

danrbailey avatar Feb 27 '20 19:02 danrbailey

Thanks Dan, I will take a look at the new helper class and rework the PR. Regarding CLA looks I need to recommit with updated email as the previous one was not associated with my GitHub account. I'll force push to update this information.

kaarrot avatar Feb 27 '20 23:02 kaarrot

I was asked by EasyCLA support to close and reopen the PR to see if this has an effect on the failing check.

kaarrot avatar Feb 28 '20 18:02 kaarrot

I'm going to wait for OVDB-136 to be merged first.

kaarrot avatar Feb 29 '20 02:02 kaarrot

The update addressed all above comments and uses new AttributeSet::Info. Based on the answer I will still need to rework PointAttrib helper struct.

kaarrot avatar Mar 02 '20 06:03 kaarrot