OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Bindings: UnknownSchema added data property

Open natchar opened this issue 1 year ago • 3 comments

Fixes #1234

Python bindings return dictionary-type python object for UnknownSchema data.

natchar avatar Sep 27 '24 23:09 natchar

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: natchar / name: Natchar (9f47a3515450defd007ce59811ad1cf73c042e1c)

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.61%. Comparing base (c0e97b0) to head (a8974b3). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...entimelineio-bindings/otio_serializableObjects.cpp 66.66% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
- Coverage   84.11%   81.61%   -2.51%     
==========================================
  Files         198      176      -22     
  Lines       22241    12344    -9897     
  Branches     4687     3024    -1663     
==========================================
- Hits        18709    10075    -8634     
+ Misses       2610     1732     -878     
+ Partials      922      537     -385     
Flag Coverage Δ
py-unittests 81.61% <88.88%> (-2.51%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/unknownSchema.h 33.33% <100.00%> (+33.33%) :arrow_up:
tests/test_unknown_schema.py 90.47% <100.00%> (+2.24%) :arrow_up:
...entimelineio-bindings/otio_serializableObjects.cpp 93.51% <66.66%> (-0.35%) :arrow_down:

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5184c36...a8974b3. Read the comment docs.

codecov-commenter avatar Sep 27 '24 23:09 codecov-commenter

This looks good to me. Once this lands, then this feature in Raven should be easy to implement: https://github.com/OpenTimelineIO/raven/issues/26

@ssteinbach do you have any concerns with this?

jminor avatar Sep 30 '24 15:09 jminor