OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Disable 32-bit Python builds

Open darbyjohnston opened this issue 1 year ago • 2 comments

Fixes #1788

This PR disables x86 builds to help reduce CI time and troubleshooting.

Marking this as WIP to test the changes.

darbyjohnston avatar Aug 26 '24 19:08 darbyjohnston

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 81.61%. Comparing base (c0e97b0) to head (2f3fb87). :warning: Report is 59 commits behind head on main.

:x: Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
- Coverage   84.11%   81.61%   -2.51%     
==========================================
  Files         198      176      -22     
  Lines       22241    12335    -9906     
  Branches     4687     3024    -1663     
==========================================
- Hits        18709    10067    -8642     
+ Misses       2610     1725     -885     
+ Partials      922      543     -379     
Flag Coverage Δ
py-unittests 81.61% <ø> (-2.51%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more. see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5184c36...2f3fb87. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Aug 26 '24 19:08 codecov-commenter

According to the documentation x86 is built by default on Windows and Linux: https://cibuildwheel.pypa.io/en/stable/options/#archs

This change specifies to only build x86_64/AMD64.

darbyjohnston avatar Aug 26 '24 19:08 darbyjohnston

Marking this as "ready for review" as discussed at the last TSC meeting.

So far there have been no responses to the OTIO slack post by @meshula that 32-bit builds are needed.

darbyjohnston avatar Sep 22 '24 23:09 darbyjohnston