OpenTimelineIO
OpenTimelineIO copied to clipboard
Added support to filepath_from_url for UNC paths and tests for UNC and posix paths
This PR is a follow up to https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1664 to add support to filepath_from_url and tests for UNC paths.
Just occurred to me, should filepath_from_url raise or do nothing if a urlstr does not have the file:// prefix? Same question if a url with a different scheme is provided?
Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.
Comparison is base (
d22935e) 79.84% compared to head (1ad7b70) 79.84%.
Additional details and impacted files
@@ Coverage Diff @@
## main #1674 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 197 197
Lines 21796 21820 +24
Branches 4358 4363 +5
=======================================
+ Hits 17403 17423 +20
- Misses 2232 2234 +2
- Partials 2161 2163 +2
| Flag | Coverage Δ | |
|---|---|---|
| py-unittests | 79.84% <87.09%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| tests/test_url_conversions.py | 95.34% <100.00%> (+2.49%) |
:arrow_up: |
| src/py-opentimelineio/opentimelineio/url_utils.py | 85.18% <63.63%> (-14.82%) |
:arrow_down: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d22935e...1ad7b70. Read the comment docs.
@douglascomet Does your latest commit resolve either of the conversations?
@douglascomet Does your latest commit resolve either of the conversations?
@meshula Yes, it will. Apologies for the delay with pushing this PR forward.
@douglascomet No need to apologize, I was just checking status, no urgency.
@douglascomet in response to:
Just occurred to me, should
filepath_from_urlraise or do nothing if a urlstr does not have the file:// prefix? Same question if a url with a different scheme is provided?
I would say it should not raise - the implication is that that is a relative URL. That does, however, imply that filepath_from_url should maybe accepts something like a base_path with is the filepath that paths can be relative to (usually this would be the path of parent dir the loaded otio file is in).
But I think this is out of scope for this PR.