OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Support for C++17

Open darbyjohnston opened this issue 2 years ago • 4 comments
trafficstars

Fixes #1526

Changes:

  • Set the C++ version to 17 and CMAKE_OSX_DEPLOYMENT_TARGET to 10.14 in the top-level CMakelist.txt file
  • Replaced any and optional dependencies with versions from the standard library
  • Removed the any and optional dependencies

(This PR replaces https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1530)

darbyjohnston avatar Feb 05 '23 18:02 darbyjohnston

Codecov Report

Merging #1539 (0ab698f) into main (80d341b) will increase coverage by 0.21%. The diff coverage is 51.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
+ Coverage   80.11%   80.32%   +0.21%     
==========================================
  Files         197      197              
  Lines       21699    21690       -9     
  Branches     4299     4251      -48     
==========================================
+ Hits        17384    17423      +39     
+ Misses       2170     2169       -1     
+ Partials     2145     2098      -47     
Flag Coverage Δ
py-unittests 80.32% <51.01%> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/opentimelineio/anyDictionary.h 87.69% <0.00%> (ø)
src/opentimelineio/anyVector.h 82.85% <ø> (ø)
src/opentimelineio/composable.cpp 54.83% <0.00%> (ø)
src/opentimelineio/composable.h 100.00% <ø> (ø)
src/opentimelineio/externalReference.h 100.00% <ø> (ø)
src/opentimelineio/generatorReference.h 100.00% <ø> (ø)
src/opentimelineio/imageSequenceReference.h 48.27% <ø> (ø)
src/opentimelineio/serializableCollection.cpp 47.72% <ø> (+2.27%) :arrow_up:
src/opentimelineio/serializableCollection.h 34.37% <ø> (ø)
src/opentimelineio/serializableObject.cpp 48.59% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80d341b...0ab698f. Read the comment docs.

codecov-commenter avatar Feb 05 '23 18:02 codecov-commenter

The PR is still showing conflicts even though the latest changes from main have been merged. Maybe the DCO failing is causing the conflicts to not be updated?

darbyjohnston avatar Dec 06 '23 18:12 darbyjohnston

It's possible. Are you able to rewrite the commits for these?

Commit sha: e6a9313, Author: Darby Johnston, Committer: GitHub; The sign-off is missing. Commit sha: 0e10458, Author: Darby Johnston, Committer: GitHub; The sign-off is missing.

meshula avatar Dec 07 '23 23:12 meshula

+1 to get this back to the main-line branch.

peter-targett avatar Feb 22 '24 12:02 peter-targett

I pressed the "Set DCO to pass" button, since @darbyjohnston has clearly asserted that these commits are fine.

jminor avatar Mar 08 '24 23:03 jminor

Superseded by #1713

reinecke avatar Mar 28 '24 22:03 reinecke