OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Added pytest assertions

Open GmoZen opened this issue 3 years ago • 3 comments

Link the Issue(s) this Pull Request is related to.

This pull request was initiated as a part of a CodeDay mentorship program.

Each PR should link at least one issue, in the form:

Partially addresses https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/1228

Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.

Summarize your change.

Replaced unittest assertions with Pytest assertions (except those for multi-line strings, as unittests assertions were more descriptive). We're migrating unit tests from vanilla unittest to Pytest to better be inline with the greater Python community.

Add a list of changes, and note any that might need special attention during review.

Reference associated tests.

test_clip.py

GmoZen avatar Jul 29 '22 21:07 GmoZen

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: GmoZen / name: Guillermo Zendejas (da5549b11e6a13389a3e6a86f1a4d243197c481d)

I like the improved readability of the new test cases.

The CI is complaining about linting errors. You can run the linter locally to ensure that your change will pass that check, via make lint. After resolving those, you can push your changes to the same branch you've been using and this PR will update & re-run the CI checks.

Also, let us know if you need help with DCO or EasyCLA. We know those can be confusing for new contributors & we're happy to explain what those are all about.

jminor avatar Aug 01 '22 16:08 jminor

I think the remaining linter issues are not your fault. See this: https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/1369

jminor avatar Aug 03 '22 18:08 jminor